From a6dc61a92408685d0d4528039a0fdd224c5d2b91 Mon Sep 17 00:00:00 2001
From: Sven Balzer <4653051+Kyuusokuna@users.noreply.github.com>
Date: Sun, 4 May 2025 11:04:01 +0200
Subject: [PATCH] add AttributeChoiceField and use it for Talent

---
 src/ItemSheets/Talent.hbs | 35 +++--------------------------------
 src/main.mjs              | 25 ++++++++++++++++++++++---
 2 files changed, 25 insertions(+), 35 deletions(-)

diff --git a/src/ItemSheets/Talent.hbs b/src/ItemSheets/Talent.hbs
index c47636b..4e10bcd 100644
--- a/src/ItemSheets/Talent.hbs
+++ b/src/ItemSheets/Talent.hbs
@@ -17,38 +17,9 @@
                 {{>editable-input type="text" name="system.behinderung" value=item.system.behinderung placeholder=(localize "DSA41.talente.label_behinderung")}}
             </div>
             <div class="grid3 gap">
-                <select name="system.attribute1">
-                    <option value="courage"      {{#if (eq item.system.attribute1 "courage")     }}selected{{/if}}>{{localize "DSA41.attributes.long.courage"}}     </option>
-                    <option value="cleverness"   {{#if (eq item.system.attribute1 "cleverness")  }}selected{{/if}}>{{localize "DSA41.attributes.long.cleverness"}}  </option>
-                    <option value="intuition"    {{#if (eq item.system.attribute1 "intuition")   }}selected{{/if}}>{{localize "DSA41.attributes.long.intuition"}}   </option>
-                    <option value="charisma"     {{#if (eq item.system.attribute1 "charisma")    }}selected{{/if}}>{{localize "DSA41.attributes.long.charisma"}}    </option>
-                    <option value="dexterity"    {{#if (eq item.system.attribute1 "dexterity")   }}selected{{/if}}>{{localize "DSA41.attributes.long.dexterity"}}   </option>
-                    <option value="agility"      {{#if (eq item.system.attribute1 "agility")     }}selected{{/if}}>{{localize "DSA41.attributes.long.agility"}}     </option>
-                    <option value="constitution" {{#if (eq item.system.attribute1 "constitution")}}selected{{/if}}>{{localize "DSA41.attributes.long.constitution"}}</option>
-                    <option value="strength"     {{#if (eq item.system.attribute1 "strength")    }}selected{{/if}}>{{localize "DSA41.attributes.long.strength"}}    </option>
-                </select>
-
-                <select name="system.attribute2">
-                    <option value="courage"      {{#if (eq item.system.attribute2 "courage")     }}selected{{/if}}>{{localize "DSA41.attributes.long.courage"}}     </option>
-                    <option value="cleverness"   {{#if (eq item.system.attribute2 "cleverness")  }}selected{{/if}}>{{localize "DSA41.attributes.long.cleverness"}}  </option>
-                    <option value="intuition"    {{#if (eq item.system.attribute2 "intuition")   }}selected{{/if}}>{{localize "DSA41.attributes.long.intuition"}}   </option>
-                    <option value="charisma"     {{#if (eq item.system.attribute2 "charisma")    }}selected{{/if}}>{{localize "DSA41.attributes.long.charisma"}}    </option>
-                    <option value="dexterity"    {{#if (eq item.system.attribute2 "dexterity")   }}selected{{/if}}>{{localize "DSA41.attributes.long.dexterity"}}   </option>
-                    <option value="agility"      {{#if (eq item.system.attribute2 "agility")     }}selected{{/if}}>{{localize "DSA41.attributes.long.agility"}}     </option>
-                    <option value="constitution" {{#if (eq item.system.attribute2 "constitution")}}selected{{/if}}>{{localize "DSA41.attributes.long.constitution"}}</option>
-                    <option value="strength"     {{#if (eq item.system.attribute2 "strength")    }}selected{{/if}}>{{localize "DSA41.attributes.long.strength"}}    </option>
-                </select>
-
-                <select name="system.attribute3">
-                    <option value="courage"      {{#if (eq item.system.attribute3 "courage")     }}selected{{/if}}>{{localize "DSA41.attributes.long.courage"}}     </option>
-                    <option value="cleverness"   {{#if (eq item.system.attribute3 "cleverness")  }}selected{{/if}}>{{localize "DSA41.attributes.long.cleverness"}}  </option>
-                    <option value="intuition"    {{#if (eq item.system.attribute3 "intuition")   }}selected{{/if}}>{{localize "DSA41.attributes.long.intuition"}}   </option>
-                    <option value="charisma"     {{#if (eq item.system.attribute3 "charisma")    }}selected{{/if}}>{{localize "DSA41.attributes.long.charisma"}}    </option>
-                    <option value="dexterity"    {{#if (eq item.system.attribute3 "dexterity")   }}selected{{/if}}>{{localize "DSA41.attributes.long.dexterity"}}   </option>
-                    <option value="agility"      {{#if (eq item.system.attribute3 "agility")     }}selected{{/if}}>{{localize "DSA41.attributes.long.agility"}}     </option>
-                    <option value="constitution" {{#if (eq item.system.attribute3 "constitution")}}selected{{/if}}>{{localize "DSA41.attributes.long.constitution"}}</option>
-                    <option value="strength"     {{#if (eq item.system.attribute3 "strength")    }}selected{{/if}}>{{localize "DSA41.attributes.long.strength"}}    </option>
-                </select>
+                {{DSA41_input "system.attribute1"}}
+                {{DSA41_input "system.attribute2"}}
+                {{DSA41_input "system.attribute3"}}
             </div>
         </div>
     </div>
diff --git a/src/main.mjs b/src/main.mjs
index 2977bd2..9d4b0ea 100644
--- a/src/main.mjs
+++ b/src/main.mjs
@@ -271,6 +271,25 @@ class AttributeField extends SchemaField {
     }
 }
 
+class AttributeChoiceField extends StringField {
+    constructor() {
+        return super({
+            required: true,
+            choices: {
+                "courage":      "DSA41.attributes.long.courage",
+                "cleverness":   "DSA41.attributes.long.cleverness",
+                "intuition":    "DSA41.attributes.long.intuition",
+                "charisma":     "DSA41.attributes.long.charisma",
+                "dexterity":    "DSA41.attributes.long.dexterity",
+                "agility":      "DSA41.attributes.long.agility",
+                "constitution": "DSA41.attributes.long.constitution",
+                "strength":     "DSA41.attributes.long.strength",
+            },
+            initial: "courage",
+        });
+    }
+}
+
 class DSA41_CharacterDocument extends Actor {
     static async create(data, operation) {
         const actor = await super.create(data, operation);
@@ -737,9 +756,9 @@ class DSA41_TalentData extends TypeDataModel {
             kategorie:   new StringField({ initial: "koerperliche" }),
             behinderung: new StringField({ initial: "" }),
 
-            attribute1: new StringField({ initial: "courage" }),
-            attribute2: new StringField({ initial: "courage" }),
-            attribute3: new StringField({ initial: "courage" }),
+            attribute1: new AttributeChoiceField(),
+            attribute2: new AttributeChoiceField(),
+            attribute3: new AttributeChoiceField(),
 
             talentwert: new NumberField({ integer: true, initial: 0 }),
         };